Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should the Dockerfile include? #165

Closed
emschwartz opened this issue Jul 26, 2019 · 2 comments
Closed

What should the Dockerfile include? #165

emschwartz opened this issue Jul 26, 2019 · 2 comments
Labels

Comments

@emschwartz
Copy link
Member

Should we keep the Dockerfile in the repo for now or take it out as proposed in #157?

If we keep the Dockerfile, should it include the:

  • Interledger.rs CLI / "node" bundle
  • settlement engines
  • redis-server
  • localtunnel or something similar

I think that in the future we'll want an image that includes the node, all of the settlement engines, and redis and/or a postgres db. However, since the settlement pieces aren't ready, is it worth having such a bundle now? We could have a very simple Dockerfile that only builds the core interledger.rs binary, but I'm not sure how useful that is. (Also, if we do that, should it include Redis or expect you to have another container running Redis?)

Thoughts?

cc @Neil-Jubinville @gakonst @bstrie @dora-gt

@Neil-Jubinville
Copy link

Neil-Jubinville commented Jul 26, 2019

My dev needs load out in the Dockerfile would be:

  • Interledger.rs CLI / "node" bundle
  • redis-server
  • localtunnel OPTIONAL ENV VAR ENABLED

I would prefer settlement engines stand alongside the ILP node on their own.

@dora-gt
Copy link
Member

dora-gt commented Jul 26, 2019

Hmmm I think we don't need docker files at least for now because the .shs are useful enough and eventually we'll have to redesign the structure, considering scaling.

Or... why don't we create the interledger.rs website and analyze the drop-rate (is the word understandable? a common word in Japan🤔) or gather comments on it of whether the explanation is understandable or not.

Of course, the cost could be controversy but I think it is worth arguing because, for the prosperity of ILP and interledger.rs, I think we should place emphasis on Developer Experience.

Btw the developer experience of Rust is really great. They present the integrated environment of packages and tests, great documents, and the compiler always suggests What to do next to solve the problem. I'm really impressed by the behavior and I would like to make the world of interledger.rs the same as Rust.

emschwartz added a commit that referenced this issue Jul 26, 2019
emschwartz added a commit that referenced this issue Jul 30, 2019
emschwartz added a commit that referenced this issue Jul 30, 2019
emschwartz added a commit that referenced this issue Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants