Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Strings to SecretStrings #556

Closed
gakonst opened this issue Dec 5, 2019 · 5 comments · Fixed by #579
Closed

Convert Strings to SecretStrings #556

gakonst opened this issue Dec 5, 2019 · 5 comments · Fixed by #579

Comments

@gakonst
Copy link
Member

@gakonst gakonst commented Dec 5, 2019

As title. Also in a few places where we use String in Warp, they can be automatically converted via Secrecy's FromStr implementation, after a new release is made.

Originally posted by @gakonst in #553

@emschwartz

This comment has been minimized.

Copy link
Member

@emschwartz emschwartz commented Dec 16, 2019

Is this still blocked?

@gakonst

This comment has been minimized.

Copy link
Member Author

@gakonst gakonst commented Dec 18, 2019

Yeah, so the Secrecy version which includes that is 0.6 which updated bytes to 0.5 which itself had a few breaking changes. I am not sure yet how much effort is required, but would probably mean the whole repo needs to move to bytes 0.5. @tarcieri do you think it'd be possible to make a minor Secrecy release as 0.5.2, with iqlusioninc/crates#309 in it? Currently evaluating how much effort might be required to upgrade to bytes

@tarcieri

This comment has been minimized.

Copy link
Collaborator

@tarcieri tarcieri commented Dec 18, 2019

Yeah, I can do that.

Also in a pinch you can include two different versions of bytes (I had to do that in the tendermint crate because Prost hasn't updated yet), but avoiding that is probably for the best.

@tarcieri

This comment has been minimized.

Copy link
Collaborator

@tarcieri tarcieri commented Dec 18, 2019

Made a backport PR here: iqlusioninc/crates#316

@tarcieri

This comment has been minimized.

Copy link
Collaborator

@tarcieri tarcieri commented Dec 18, 2019

gakonst added a commit that referenced this issue Dec 20, 2019
Fixes #556
@gakonst gakonst closed this in #579 Dec 21, 2019
gakonst added a commit that referenced this issue Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.