Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STREAM fail-fast should ignore temporary errors #633

Closed
kincaidoneil opened this issue Feb 26, 2020 · 0 comments
Closed

STREAM fail-fast should ignore temporary errors #633

kincaidoneil opened this issue Feb 26, 2020 · 0 comments

Comments

@kincaidoneil
Copy link
Collaborator

@kincaidoneil kincaidoneil commented Feb 26, 2020

The fail-fast behavior I implemented of 200+ packets and 99% failure rate doesn't work under liquidity errors/waiting for settlements. If there are insufficient liquidity errors that take a second or more to resolve, it'll hit the 99%+ error rate since the Rust implementation retries packets so quickly.

T04s (and maybe other temporary errors) should not affect the fail-fast behavior.

kincaidoneil added a commit that referenced this issue Feb 28, 2020
- fix #513: compute min source amount necessary to deliver money to fix T04 issues
- fix #634: distribute dust amounts across remaining packets
- fix #633: only apply T00, T01, F99 to fail-fast behavior
- fix #467: continue on R01, other relative others should be terminal
- increase default slippage to 1.5%
@gakonst gakonst closed this in #635 Mar 25, 2020
gakonst pushed a commit that referenced this issue Mar 25, 2020
- fix #513: compute min source amount necessary to deliver money to fix T04 issues
- fix #634: distribute dust amounts across remaining packets
- fix #633: only apply T00, T01, F99 to fail-fast behavior
- fix #467: continue on R01, other relative others should be terminal
- increase default slippage to 1.5%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.