Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STREAM sender reliability improvements #635

Merged
merged 1 commit into from Mar 25, 2020
Merged

STREAM sender reliability improvements #635

merged 1 commit into from Mar 25, 2020

Conversation

@kincaidoneil
Copy link
Collaborator

kincaidoneil commented Feb 28, 2020

  • Fix #513: Compute minimum source amount necessary to deliver money, corresponding to the minimum destination amount. This enables STREAM payments across peers in which a credit limit is hit and settlement occurs during the payment. Previously, T04s would reduce the source amount to 1, which will always fail due to rounding or not meeting the minimum exchange rate.
  • Fix #634: Distribute dust amounts across remaining packets. By chance, the last packet in a STREAM payment may be too small that it won't meet the minimum destination amount due to rounding errors. This heuristic approximates in advance if this may happen and increases each packet amount slightly so there's no dust amount.
  • Fix #633: Only apply T00, T01, F99 to fail-fast behavior. e.g. T04s should not trigger the fail-fast behavior, since they take time to resolve, not simply a number of packets -- this was a bug.
  • Fix #467: Continue sending on R01 errors, which are triggered when the router receives a packet that rounds to 0. For other relative errors, e.g. R00, R02, the behavior stays the same, since they're likely terminal.
  • Increase default slippage to 1.5%. This is so if operators set a 1% spread, the sender works by default.
- fix #513: compute min source amount necessary to deliver money to fix T04 issues
- fix #634: distribute dust amounts across remaining packets
- fix #633: only apply T00, T01, F99 to fail-fast behavior
- fix #467: continue on R01, other relative others should be terminal
- increase default slippage to 1.5%
@kincaidoneil kincaidoneil requested a review from gakonst Feb 28, 2020
@kincaidoneil kincaidoneil requested a review from emschwartz as a code owner Feb 28, 2020
@gakonst gakonst merged commit 5276479 into master Mar 25, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-md Your tests passed on CircleCI!
Details
@gakonst gakonst deleted the ko-stream-reliability branch Mar 25, 2020
@gakonst

This comment has been minimized.

Copy link
Member

gakonst commented Mar 25, 2020

LGTM! These last few changes on STREAM really improved it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.