Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bring user response type into shared package #1434

Merged
merged 3 commits into from
Jul 11, 2024
Merged

feat: bring user response type into shared package #1434

merged 3 commits into from
Jul 11, 2024

Conversation

domin191013
Copy link
Contributor

Context

Changes

@domin191013 domin191013 self-assigned this Jul 8, 2024
@github-actions github-actions bot added package: wallet/frontend Wallet frontend implementations package: wallet/backend Wallet backend implementations type: source Source changes labels Jul 8, 2024
beniaminmunteanu
beniaminmunteanu approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@beniaminmunteanu beniaminmunteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2 cents is renaming to Profile, I find it a better name suited for the current logged in user getting his own info.
User could be reserved for any other user.

LGTM though 🚀

@domin191013 domin191013 merged commit 53028e3 into main Jul 11, 2024
15 checks passed
@domin191013 domin191013 deleted the shared-wallet-user branch July 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragosp1011 dragosp1011 dragosp1011 approved these changes

@beniaminmunteanu beniaminmunteanu beniaminmunteanu approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees

@domin191013 domin191013

Labels
package: wallet/backend Wallet backend implementations package: wallet/frontend Wallet frontend implementations type: source Source changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Subtask] - Open API for User
3 participants
@domin191013 @dragosp1011 @beniaminmunteanu