Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(middleware): move middleware composition code to pipeline class #449

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@justmoon
Copy link
Contributor

commented Jul 26, 2018

Composing middleware is really only done by middleware pipelines, so it should be part of the MiddlewarePipeline class, not in utils.ts.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 26, 2018

Codecov Report

Merging #449 into master will decrease coverage by 0.68%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   74.82%   74.13%   -0.69%     
==========================================
  Files          47       46       -1     
  Lines        2367     2177     -190     
  Branches      387      363      -24     
==========================================
- Hits         1771     1614     -157     
+ Misses        596      563      -33
Impacted Files Coverage Δ
src/lib/utils.ts 82.6% <ø> (-1.88%) ⬇️
src/services/middleware-manager.ts 81.05% <66.66%> (-0.67%) ⬇️
src/lib/middleware-pipeline.ts 54.54% <93.33%> (+24.54%) ⬆️
src/services/admin-api.ts 38.37% <0%> (-17.77%) ⬇️
src/middlewares/balance.ts 70.17% <0%> (-4.66%) ⬇️
src/errors/invalid-json-body-error.ts 46.66% <0%> (-3.34%) ⬇️
src/controllers/ilp-prepare.ts 88.23% <0%> (-0.96%) ⬇️
src/services/accounts.ts 65.17% <0%> (-0.9%) ⬇️
src/index.ts 23.07% <0%> (ø) ⬆️
src/common/log.ts 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df718d...2ce1c2d. Read the comment docs.

@traviscrist traviscrist requested a review from sharafian Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.