Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor cleanup #463

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@justmoon
Copy link
Contributor

commented Oct 17, 2018

Some assorted minor cleanup things. (Did a tour of the codebase for someone and noticed these issues.)

@justmoon justmoon requested a review from sentientwaffle Oct 17, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Oct 17, 2018

Codecov Report

Merging #463 into master will increase coverage by 0.01%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #463      +/-   ##
=========================================
+ Coverage   71.68%   71.7%   +0.01%     
=========================================
  Files          44      44              
  Lines        2038    2032       -6     
  Branches      327     327              
=========================================
- Hits         1461    1457       -4     
+ Misses        577     575       -2
Impacted Files Coverage Δ
src/services/core.ts 72% <ø> (-3.87%) ⬇️
src/app.ts 55.26% <0%> (+1.41%) ⬆️
src/services/route-builder.ts 90.38% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00e24d...d210fba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.