Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #481

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@karzak
Copy link

commented Mar 7, 2019

Latest install had a bunch of medium and one high vulnerability.

@karzak karzak requested a review from kincaidoneil Mar 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Mar 7, 2019

Codecov Report

Merging #481 into master will increase coverage by 3.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   66.64%   70.32%   +3.67%     
==========================================
  Files          44       44              
  Lines        1826     1584     -242     
  Branches      309      127     -182     
==========================================
- Hits         1217     1114     -103     
+ Misses        483      424      -59     
+ Partials      126       46      -80
Impacted Files Coverage Δ
src/controllers/ccp.ts 61.11% <0%> (-2.05%) ⬇️
src/services/store.ts 78.57% <0%> (-1.43%) ⬇️
src/routing/dragon.ts 31.25% <0%> (-0.33%) ⬇️
src/middlewares/alert.ts 93.33% <0%> (-0.22%) ⬇️
src/services/config.ts 77.27% <0%> (-0.09%) ⬇️
src/lib/token-bucket.ts 100% <0%> (ø) ⬆️
src/services/admin-api.ts 52% <0%> (+1.23%) ⬆️
src/services/accounts.ts 60% <0%> (+1.66%) ⬆️
src/middlewares/stats.ts 68.57% <0%> (+1.9%) ⬆️
src/middlewares/balance.ts 68.37% <0%> (+1.95%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5145586...2183791. Read the comment docs.

@adrianhopebailie

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@karzak or @kincaidoneil I tried resolving a merge conflict in the package lockfile but Snyk didn't like my manual tweaks 😢

https://support.snyk.io/hc/en-us/articles/360000910057-Manifest-and-lockfile-out-of-sync

Can you push your latest to correct package-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.