Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pay): open payments support #56

Merged
merged 1 commit into from Jun 24, 2020
Merged

Conversation

kincaidoneil
Copy link
Member

  • Resolve and pay Open Payments invoices with invoiceUrl option
  • Add docs, schema, and validation for invoices
  • Query Open Payments account in parallel with SPSP query
  • Simplify some config options
  • Improve test coverage to 100%
  • Fix probed exchange rate mistakenly reset
  • Fix sending u64 probe packet, rate would incorrectly be 1:1
  • Update deps for all packages, miscellaneous fixes

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   90.04%   90.68%   +0.63%     
==========================================
  Files          33       32       -1     
  Lines        2201     2297      +96     
  Branches      380      400      +20     
==========================================
+ Hits         1982     2083     +101     
+ Misses        219      214       -5     
Flag Coverage Δ
#connection_tag_utils 100.00% <ø> (ø)
#ilp_logger 91.66% <ø> (ø)
#ilp_packet 63.84% <ø> (ø)
#ilp_plugin 100.00% <ø> (ø)
#ilp_protocol_ccp 98.78% <ø> (ø)
#ilp_protocol_ildcp 100.00% <ø> (ø)
#ilp_spsp_payout 14.39% <ø> (ø)
#oer_utils 99.37% <ø> (ø)
#pay 100.00% <100.00%> (+0.47%) ⬆️
Impacted Files Coverage Δ
packages/pay/src/controllers/failure.ts 100.00% <ø> (ø)
packages/pay/src/connection.ts 100.00% <100.00%> (ø)
packages/pay/src/controllers/amount.ts 100.00% <100.00%> (ø)
packages/pay/src/controllers/asset-details.ts 100.00% <100.00%> (ø)
packages/pay/src/controllers/exchange-rate.ts 100.00% <100.00%> (ø)
packages/pay/src/controllers/max-packet.ts 100.00% <100.00%> (ø)
packages/pay/src/controllers/rate-probe.ts 100.00% <100.00%> (ø)
packages/pay/src/controllers/sequence.ts 100.00% <100.00%> (+14.28%) ⬆️
packages/pay/src/index.ts 100.00% <100.00%> (ø)
packages/pay/src/open-payments.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcb132...b9b838b. Read the comment docs.

packages/pay/README.md Outdated Show resolved Hide resolved
packages/pay/src/controllers/max-packet.ts Outdated Show resolved Hide resolved
packages/pay/src/controllers/max-packet.ts Show resolved Hide resolved
Copy link

@matdehaast matdehaast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/pay/src/index.ts Show resolved Hide resolved
- resolve and pay Open Payments invoices with `invoiceUrl` option
- add docs, schema, and validation for invoices
- resolve Open Payments accounts in parallel with SPSP query
- improve test coverage to 100%, better validation and other tests
- fix: probed exchange rate mistakenly reset
- fix: don't send u64 probe packet, rate may incorrectly be 1:1
- update deps for all packages
- try to fix issue with pay flag coverage reported incorrectly
- fix vscode not respecting gitignore
@kincaidoneil kincaidoneil merged commit 2d4ba19 into master Jun 24, 2020
@kincaidoneil kincaidoneil deleted the ko/pay-open-payments branch July 27, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants