This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Set up rust #119
Merged
Set up rust #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move the install instructions out, and fix them up.
| ``` | ||
|
|
||
| This is our main function, which is traditionally called `kmain()`, for 'kernel | ||
| main.' We need to use the `#[no_mangle] and `pub extern` annotations to indicate |
| This is our main function, which is traditionally called `kmain()`, for 'kernel | ||
| main.' We need to use the `#[no_mangle]` and `pub extern` annotations to indicate | ||
| that we're going to call this function like we would call a C function. The `-> !` | ||
| indicates that this function never returns. And in fact, it does not: the body |
There was a problem hiding this comment.
Hmmm, I think this is one of things things in which English is ambiguous.
And in fact, it does not return
is how I read this, but you're reading it as negating the "never returns."
There was a problem hiding this comment.
Yes, could you change it to it does not return?
| In this case, the reason we need `unsafe` is the next two lines: we create a | ||
| pointer to `0xb8000`, and then write some numbers to it. Rust cannot know that | ||
| this is safe; if it did, it would have to understand that we are a kernel, | ||
| and understand the VGA specification. Having a programming langauge understand |
There was a problem hiding this comment.
i am the worst. thanks for finding these
|
Thanks everyone, I've addressed the nits. Also, I wrote an aside pointing to an example of a more DRY makefile. |
as discovered in intermezzOS/kernel#45, the focus on the .a wouldn't actually cause things to be rebuilt. This will.
|
I am too excited to get this merged, and so I'm going to go ahead and do it. If you didn't get the chance to check this chapter out yet, please open issues with anything you want to comment on! Still very happy to get feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Here's the next chapter! We finally have Rust code!