This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Remove unsafe from Vga's constructor. #66
Merged
+32
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
force-pushed
the
remove_unsafety
branch
from
2492f07
to
6efe970
Compare
steveklabnik
force-pushed
the
remove_unsafety
branch
from
9b7f7f8
to
20216e6
Compare
Turns out, we don't need to worry about this! We can accept a mutable slice instead, and panic if it's the wrong length. This now means that the VGA driver is 100% safe, and the only mention of unsafety in the kernel at all is the creation of the slice to video memory. Since I was changing the signature of Vga::new, I also cleaned up some of the const fn stuff that used to matter when we had a static Vga, but now do not.🤘
steveklabnik
force-pushed
the
remove_unsafety
branch
from
20216e6
to
2a020eb
Compare
steveklabnik
added a commit
to intermezzOS/vga
that referenced
this pull request
Sep 27, 2016
No more need for the print stuff, and all the other simplifications from intermezzOS/kernel#66
I remembered part of what @whitequark did, but not the last part. https://www.reddit.com/r/rust/comments/51c15r/log_buffer_a_zeroallocation_ring_buffer_for/d7asb76?st=itks4seg&sh=a52734ef This improves ergonomics quite a bit!🤘
steveklabnik
force-pushed
the
remove_unsafety
branch
from
2a020eb
to
6f440fe
Compare
|
I want to ship this so that I can reorganize the repo, so I'm merging. If anyone has beef with any of this, please file issues! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Turns out, we don't need to worry about this! We can accept a mutable
slice instead, and panic if it's the wrong length.
This now means that the VGA driver is 100% safe, and the only mention of
unsafety in the kernel at all is the creation of the slice to video
memory.
Since I was changing the signature of Vga::new, I also cleaned up some🤘
of the const fn stuff that used to matter when we had a static Vga, but
now do not.