This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Interrupts #72
Merged
Interrupts #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Support creating an IdtRef in the kernel::Context. This will be something like a Vec or String: it will refer to the actual IDT, which is static. 2. Make a factory function for the IdtRef, so that the other crate can get one.
|
@ketsuban comments on IRC
|
steveklabnik
force-pushed
the
interrupts
branch
from
c46637b
to
ee054fd
Compare
Lots to go over here! This step is pretty big. 1. Add a pic crate, we need to remap the pic to enable interrupts. 2. Create the trampoline for creating interrupts 3. Set up the GPF handler. All unused interrupts go here, thanks to the x86 crates' MISSING handler. 4. Set up the timer handler. We don't want to do anything with it yet. 5. Set up panic to print something. Okay, so #5 really, really isn't great. I'm not sure how to get around it, though. Basically, we have to create a static reference to the thing we're trying to not keep static. It's gross. Idk.
This is just too much of a PTA in too many places. This code is cleaner, even though things are global.
This is more idiomatic.
steveklabnik
force-pushed
the
interrupts
branch
from
2a1ca75
to
cb87ba6
Compare
|
I think this is good to go |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Re-introduce interrupts.
x86 crates' MISSING handler.
Okay, so 5 really, really isn't great. I'm not sure how to get around
it, though. Basically, we have to create a static reference to the thing
we're trying to not keep static. It's gross. Idk.