New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genome browser #1177
Comments
I've done a quick survey of the genome browsers out there. Many are old, unmaintained or wouldn't be possible to embed. Of the ones that are left
For now, I'm going to see how easy it will be to get the jbrowse issue fixed. |
The current issue with jbrowse is that it displays on Chrome but not on Firefox (blank iframe instead). The setup is that jbrowse is hosted remotely and fetches it's data via CORS requests to the mine. However, it doesn't look like CORS is the issue. jbrowse works fine both it and the mine are hosted locally. Perhaps this is some timing issue. I intend to ask on the jbrowse dev list to see if they can shed any light once I have a public example up displaying this problem. |
I'd be happy to look at this if there is still interest. I was testing out adding the config like in 4318f0e and I saw the jbrowse frame could load, but not the features necessarily. |
Actually, after this I discovered that one of my Firefox plugins (NoScript) was stopping jbrowse displaying, though Julie has also had trouble with Chrome (which is fine for me). I do have fixes for jbrowse integration for InterMine in branch [1]. This is not yet merged with intermine/dev. What would be really handy for InterMine is if there was some way of loading jbrowse.conf from InterMine instead of having to specify it jbrowse side, since some mines have organisms that change between builds and getting jbrowse.conf would allow us to host one jbrowse installation (on the CDN) rather than one for each mine. For some reason I thought this had already been implemented but I think I was mistaken. Any thoughts about this, Colin? [1] https://github.com/justincc/intermine/tree/jbrowse-fixes |
Yes, it was blank until I turned off my adblocker. Try that @cmdcolin? But when JBrowse did appear, the genes didn't show up as expected. There was some data if I scrolled to the left or out but there was some missing etc. It's going to take some investigation to find out why the data is wrong. @justinccdev You got it working for synbiomine? Is that public? @sergiocontrino You got it working for thalemine? Is that public? |
@julie I have it active on the beta Synbiomine. For instance, [1]. For me, at least for the genes I've looked at, the tracks appear as I would expect. [1] http://beta.synbiomine.org/synbiomine/report.do?id=26026345 |
I see approximately this scenario on my test mine as well. I am pretty familiar with this type of thing in jbrowse though, it is just data formatting issues I believe which the backend should be able to control. For example the above formatting issues are pretty typical (the one with bold letters but no features showing is one type of thing, and also features but with no subfeatures is another) @justinccdev I'd be interested but basically something like that should be fine. JBrowse has a flexible concept of "including" config files from different locations and merging them into the final config. I note that the jbrowse instance is on the cdn, but it shouldn't be a problem to add extra custom config on the mine site too (and the settings inside for example in a trackList.json file can contain both track configs and global config settings) |
Hi All, In the most recent public build of ThaleMine, we (@sergiocontrino along with @justinccdev) have been able to resolve any remaining issues with the Please see this example ThaleMine gene report: https://apps.araport.org/thalemine/portal.do?class=Gene&externalids=AT1G67140 Apart from the fixes on the InterMine side of things, we also had to tweak the JBrowse ProcessedTranscript glyph, so that the "CDS" feature loaded into ThaleMine, which is stored as a single block with [start, end] coordinates (similar to how it is stored in FlyMine), can be broken up into CDS parts (describing the splicing structure), and then correctly rendered in the JBrowse view. The JBrowse code changes can be seen in this commit: Arabidopsis-Information-Portal/jbrowse@a1f7a21 In order for both these changes to work in concert, we've added a new Hope that I've been able to explain this properly! Thank you. |
cc @sammyjava, the Legume Federation InterMine instances would also benefit from code fixes described in this issue. |
Sounds good, I'll use your jbrowse fork and the new web.properties entry. I presume your updates to PopulateChildFeatures.java will be pulled into origin/dev at some point (I'm showing Julie/Jan 11 for the current version). |
Hi @sammyjava , that's correct. Need to extract the JBrowse specific changes and issue a PR to the main InterMine repo. Will notify you when that is done! Thank you. |
Hi @vivekkrish. My changes are now in [1] against InterMine/dev and I believe @julie-sullivan is looking at this. @sergiocontrino 's changes after this are in his branch [2] I think - I'm not sure if there is a cleaner one since it looks like some of them might be Thalemine specific. I think it should be possible to pull out the jbrowse changes with a bit of looking if you want. Back when I did this in December, I wrote a design doc [3] which does detail the extra mechanism for specifying jbrowse config parameters via InterMine config. Can your inferCdsParts setting conform to this format? [1] #1426 |
Hi @justinccdev , Regarding [1], was not aware of the existing PR. Thanks! [3], I did not know that this design doc existed, but I did figure out that such functionality exists by looking at the code/comments. However, for some reason I assumed (not sure why!) that this probably only applied to JBrowse track styling. I would be happy to change this to use your existing config mechanism. For example, I believe I would need to add 2 new web.properties entries like so:
This, I'm assuming, should enable Thank you! |
Hi @vivekkrish. To answer your points: [1] Yeah, I actually only created the PR today on request, as I did my part of the work in Dec 2015 but then for various reasons never merged it to the main InterMine dev. I just merged this PR along with a single change from @sergiocontrino's branch (d1c0550) because this was necessary to stop Checkstyle from complaining. I hope this gives you a good basis for building a further PR from @sergiocontrino's work and your changes? Will this be all the changes related to jbrowse that Sergio did or do you just need a subset? Unfortunately, I don't know exactly when Sergio might be around to comment if necessary. [3] Yeah, sorry, I actually meant to clean up and publish this to the InterMine mailing list for comment last December but didn't because I didn't get to the point of being ready to merge back then. When jbrowse changes are completed I'll merge the documentation parts into the main documentation. Yeah, it should be possible to do
as anything after |
hi @vivekkrish and @justinccdev, i'll do the merging of thalemine changes in a dev branch. we can then test them on humanmine when convenient for @julie-sullivan. |
JBrowse is working correctly in all mines now. |
Options:
Tell @rachellyne
The text was updated successfully, but these errors were encountered: