New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If user clicks on search without entering a term, do nothing #329

Closed
julie-sullivan opened this Issue May 30, 2013 · 0 comments

Comments

Projects
None yet
2 participants
@julie-sullivan
Member

julie-sullivan commented May 30, 2013

@ZFIN and @kkarra pointed out that when you search for an empty string OR you search for the default value (e.g. "fgf8a" in zfinmine), the search returns the entire index. This takes a long time and sometimes times out.

  • Instead, when a user clicks without typing in anything, can we take no action? Instead of returning the entire search index.
  • Also, do we want to allow the user to search for the default value? I think that should be okay to do?

In the case of ZFIN mine, the example value is fgf8a, so when @ZFIN searched for that value the entire search index was returned. The code thought the user has accidentally pressed enter without entering a value (because the default value == the typed in value).

  1. We may not need to check if entered value == default value. Just let the user search for it?
  2. If we do, is there a cleverer way to detect if a user typed anything besides doing a string comparison?

In other mines the example is something you would not search for so this hasn't been a problem in the past, e.g.:

yeastmine: e.g. act1
flymine: e.g. zen, Q9V48E

@ghost ghost assigned radekstepan May 30, 2013

radekstepan added a commit that referenced this issue Jun 3, 2013

radekstepan added a commit that referenced this issue Jun 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment