Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NetHTTPS type #1308

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
3 participants
@jogoodma
Copy link
Contributor

commented Feb 18, 2016

Hi,

I added the NetHTTPS type after Joe had some issues using HTTPS for the web service.

I am not very familiar with this code base, so please do review these changes carefully. I ran a single test to double check that my changes didn't break anything obvious.

prove -I lib -I../InterMine-Model/lib/ t/06_service/02_result_iterator.t
t/06_service/02_result_iterator.t .. ok
All tests successful.
Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.39 cusr 0.01 csys = 0.42 CPU)
Result: PASS

Cheers,
Josh

@julie-sullivan

This comment has been minimized.

Copy link
Member

commented Feb 18, 2016

@sergiocontrino

This comment has been minimized.

Copy link
Member

commented Aug 26, 2016

this has been successfully tested applying the code changes to thalemine (merged with intermine 1.6.6), deploying a webapp and using the perl webservice on it (thanks @vivekkrish!).
i'll merge if there is no objection to the testing procedure.

@julie-sullivan

This comment has been minimized.

Copy link
Member

commented Aug 30, 2016

Yes, sounds good @sergiocontrino!

@sergiocontrino sergiocontrino merged commit 92fac84 into intermine:dev Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.