Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade emberfire #354

Draft
wants to merge 43 commits into
base: master
from

Conversation

@oskarrough
Copy link
Member

commented Jul 19, 2019

Work in progress to upgrade emberfire from version 2 to 3. Using this PR to keep track of progress and what needs to be done.

Blocking

  • Fix login. There are errors in console to follow. Time to use ember simple auth instead?
  • Fix "init" bug in Emberfire (firebase/emberfire#582) - for now, I hardcode it in node_modules after yarn install to get it working. vim node_modules/emberfire/addons/services/firebase-app.ts replace line 28 with super.init(...arguments)

To test

Authentication

Torii hasn't been updated for years and Emberfire works easier with ember-simple-auth now

  • Replace torii with simple-auth
  • Create user should work
  • Replace our own authenticatedRoute mixin with that of simple auth
  • Google login
  • Facebook login
  • Email login
  • Logout
  • Test authenticated routes work
  • Make sure we use new session service from simple-auth, not torii. has to be injected
  • test all the linking stuff on /settings

Not tried yet

  • Writing/saving data

Also see

@oskarrough oskarrough self-assigned this Jul 20, 2019

@oskarrough

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2019

Couldn't make timestamps work. Hardcoded it as {'.sv': 'timestamp'} for now and opened an issue on emberfire.

@oskarrough oskarrough changed the title WIP Upgrade emberfire Upgrade emberfire Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.