Support jQuery 1.6+ #18

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@rrotter

Changed .attr to .prop where appropriate to support jQuery 1.6+. This
breaks support for any jQuery version prior to 1.6.

@rrotter rrotter Support jQuery 1.6+
Changed .attr to .prop where appropriate to support jQuery 1.6+. This
breaks support for any jQuery version prior to 1.6.
17ad4ca
@mangtronix

Thanks very much for the patch. I'm in the process of updating the plugins that we use on archive.org to use the newer jQuery.

@mkorcy

Just ran into this problem myself, thanks for the fix.

@mangtronix

Is this patch still necessary for jQuery 1.6.1+? It looks like they changed .attr back to the old behaviour.

@rrotter

Really? I haven't tested my bookreader based code without this patch since I sumitted it, but I originally developed it working with JQuery 1.7.x, and I have tested with 1.6.x, but probably not 1.6.0, I'm fairly sure it is still required on all versions 1.6 and up.

@mkorcy

Yeah I found it was necessary in 1.7 as well.

@Philomelos

I just changed the code, now the colorbox-divs not appearing anymore. Anyone knows a workaround? Or to say it in other words: Should I change Colorbox to the newest version too and everything's working fine again or is there a problem after changing to the newer Version of jquery?

@ruebot ruebot referenced this pull request in Islandora/internet_archive_bookreader Jan 21, 2014
Closed

jQuery 1.7+ support #1

@nikolas

So, should this get merged? If so, the PR I've opened for jQuery 1.5.2 here: #41 can be closed.

@rrotter

it's dead jim

@rrotter rrotter closed this Dec 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment