New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Pass rendered DOM to youtube-dl instead of asking youtube-dl to download the page from the original URL #106

Open
ctsrc opened this Issue Apr 6, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ctsrc
Copy link

ctsrc commented Apr 6, 2018

Many sites add video dynamically with JavaScript (such as what turned out to be the case with issue #104).

youtube-dl does not execute JavaScript. Instead, where video is added dynamically, youtube-dl relies on custom code for getting the video URLs for a page.

That works great when someone has written an extractor already, but in a lot of cases there has not been written any such extractor.

If instead of asking youtube-dl to download from the original URL, the rendered DOM was passed to youtube-dl then in cases where the JavaScript execution that has happened placed <video> and <source> tags in the DOM, youtube-dl should be able to find the video.

In other situations, passing the rendered DOM instead might possibly make it so that youtube-dl fails instead. In that case, perhaps it could be an option that you provide to brozzler-new-site whether to pass rendered DOM or have youtube-dl download the page from the original URL.

Let me know what you think. I know that feature requests in general are tall orders but I believe this would be useful and I hope you will consider it.

@ctsrc ctsrc changed the title Feature request -- pass rendered DOM to youtube-dl instead of asking youtube-dl to download the page from the original URL Feature request: Pass rendered DOM to youtube-dl instead of asking youtube-dl to download the page from the original URL Apr 6, 2018

@nlevitt

This comment has been minimized.

Copy link
Member

nlevitt commented Apr 6, 2018

This is a cool idea. But it's one of those things that I probably won't have time to implement myself (unless it happens to be needed to solve some issue that comes up at work). Contributions are most welcome though, and I'm happy to help point you in the right direction.

@ctsrc

This comment has been minimized.

Copy link

ctsrc commented Apr 6, 2018

Understandable :) I am a bit too busy myself for this atm but I would like to give it a shot in the future.

Can you "assign" this issue to me in GitHub so that I don't forget about it?

@nlevitt nlevitt assigned nlevitt and ctsrc and unassigned nlevitt Apr 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment