New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosts report #123

Merged
merged 5 commits into from Jan 15, 2016

Conversation

Projects
None yet
2 participants
@kris-sigur
Collaborator

kris-sigur commented Jul 13, 2015

Addresses HER-2084.

I also used the opportunity to weed a bit of unused code related to hosts reporting.

kris-sigur added some commits Jul 13, 2015

Remove unused "top" hosts tracking.
This used to be used for an overview report that was available in the H1
UI. Had become vestigial code that served no purpose.
Make sorting of host report configurable.
Can now set a maximum size for sorted reports. Longer reports are
unsorted. Default behavior is still to sort all reports.
Default profile updated to reflect this new option in a commented-out
section.
Enable suppression of empty hosts in report.
Until now hosts that have never been crawled are included in the hosts
report. This can be a very large number of hosts and is infrequently of
interest. This makes it possible to exclude the empty hosts from the
report. Default behavior remains to include them.
The option is highlighted by including it in the relevant, commented-out
section of the default profile.

nlevitt added a commit that referenced this pull request Jan 15, 2016

@nlevitt nlevitt merged commit cc97f01 into internetarchive:master Jan 15, 2016

@nlevitt

This comment has been minimized.

Show comment
Hide comment
@nlevitt

nlevitt Jan 15, 2016

Member

Thanks Kris. Only things I noticed were some mixing of tabs and spaces (heritrix convention is spaces); and properties with default values in profile-crawler-beans.cxml are normally commented out. But I figure those aren't blockers.

Member

nlevitt commented Jan 15, 2016

Thanks Kris. Only things I noticed were some mixing of tabs and spaces (heritrix convention is spaces); and properties with default values in profile-crawler-beans.cxml are normally commented out. But I figure those aren't blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment