New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle login forms with <input type="text"> fields in addition to use… #143

Merged
merged 2 commits into from Jan 19, 2016

Conversation

Projects
None yet
2 participants
@nlevitt
Member

nlevitt commented Jan 15, 2016

…rname (for this to work there must be exactly one input field whose name contains the string "username")

nlevitt added some commits Jan 15, 2016

handle login forms with <input type="text"> fields in addition to use…
…rname (for this to work there must be exactly one input field whose name contains the string "username")
Merge branch 'master' into form-login-extra-inputs
* also fix new FormLoginProcessorTest.testFormLoginExtraInputs() in context of form-login-multipart changes

* master:
  fix NullPointerException when using old HtmlFormCredential login
  to make this branch only about multipart/form-data, undo the changes to handle more complicated forms with extra input fields; add unit test; store CrawlURI submit data in http-library agnostic way and remove httpcomponents-specific code from HTMLForm, refactor creation of post data accordingly
  Be sure to return at least one of the candidates
  Remove unneeded constant
  Make sure to check form encoding type when addign form to curi data
  More changes for https://webarchive.jira.com/browse/ARI-4656
  More changes
  Save enctype of form in submission curi
  Add ability to submit forms with enctype="multipart/form-data"
  If multiple username inputs in login form, favor the one with the word 'login' in it.

vonrosen pushed a commit that referenced this pull request Jan 19, 2016

Hunter
Merge pull request #143 from nlevitt/form-login-extra-inputs
handle login forms with <input type="text"> fields in addition to use…

@vonrosen vonrosen merged commit 34c9096 into internetarchive:master Jan 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment