New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't canonicalize source tag so that SourceSeedDecideRule will work.… #148

Merged
merged 2 commits into from Feb 17, 2016

Conversation

Projects
None yet
2 participants
@vonrosen
Contributor

vonrosen commented Feb 16, 2016

… Trailing slash of canonicalized seed currently causes it not to work.

Hunter Stern
Don't canonicalize source tag so that SourceSeedDecideRule will work.…
… Trailing slash of canonicalized seed currently causes it not to work.
@nlevitt

This comment has been minimized.

Show comment
Hide comment
@nlevitt

nlevitt Feb 17, 2016

Member

This happens earlier in the method:

        if (!uri.matches("[a-zA-Z][\\w+\\-]+:.*")) { // Rfc2396 s3.1 scheme,
                                                     // minus '.'
            // Does not begin with scheme, so try http://
            uri = "http://" + uri;
        }

Source tag ought to be set to original original uri, without "http://" prepended in case it gets prepended.

Member

nlevitt commented Feb 17, 2016

This happens earlier in the method:

        if (!uri.matches("[a-zA-Z][\\w+\\-]+:.*")) { // Rfc2396 s3.1 scheme,
                                                     // minus '.'
            // Does not begin with scheme, so try http://
            uri = "http://" + uri;
        }

Source tag ought to be set to original original uri, without "http://" prepended in case it gets prepended.

nlevitt added a commit that referenced this pull request Feb 17, 2016

Merge pull request #148 from vonrosen/ARI-4738
Don't canonicalize source tag so that SourceSeedDecideRule will work.…

@nlevitt nlevitt merged commit 8474007 into internetarchive:master Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment