Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue on Privacy Settings #7679

Closed
edent opened this issue Mar 17, 2023 · 4 comments · Fixed by #7680
Closed

Accessibility issue on Privacy Settings #7679

edent opened this issue Mar 17, 2023 · 4 comments · Fixed by #7680
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@edent
Copy link

edent commented Mar 17, 2023

Evidence / Screenshot (if possible)

Screenshot 2023-03-17 at 11 24 00

Relevant url?

https://openlibrary.org/account/privacy

Steps to Reproduce

  1. Go to your privacy settings
  2. Click on the word yes or no
  3. Observe that the radio button doesn't change
  • Actual: Radio doesn't toggle
  • Expected: Radio should toggle

Details

  • Logged in (Y/N)? Y
  • Browser type/version? Firefox 120
  • Operating system? MacOs
  • Environment (prod/dev/local)? prod

Proposal & Constraints

<label for="u0">Yes</label>

Should be:

<label for="r0">Yes</label>

"no" needs to be changed to "r1"

Related files

Stakeholders
@edent edent added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Mar 17, 2023
@cdrini cdrini mentioned this issue Mar 17, 2023
Merged
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 21, 2023
@abelaba
Copy link

abelaba commented Mar 24, 2023

Hi @edent I would really like to contribute to this project, can I work on this issue?

@edent
Copy link
Author

edent commented Mar 24, 2023

@abelaba go for it!

@scottbarnes
Copy link
Collaborator

scottbarnes commented Mar 24, 2023 •
edited

Hi, @abelaba and @edent. It looks as if @cdrini has linked a PR, #7680, that will close this. It's on testing at https://testing.openlibrary.org/account/privacy and you can double check it and if you have any feedback it would be great to leave it over in #7680.

@scottbarnes scottbarnes removed the Good First Issue Easy issue. Good for newcomers. [managed] label Mar 24, 2023
@abelaba
Copy link

abelaba commented Mar 24, 2023

Okay @edent and @scottbarnes thank you for the swift response. I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve privacy settings page i18n/a11y cdrini/openlibrary
4 participants
@edent @mekarpeles @scottbarnes @abelaba