Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Docker Branch, can co-exist with current Vagrant workflow #1012
I believe this is ready for merging. Ideally all the services will NOT be in the one container, but this is a starting point to begin with something that runs as well as the Vagrant dev env as a working baseline.
This might explain why tomcat7 is reporting failure on service start, even though it appears to be running:
I could then access openlibrary locally running docker \o/ Although I got 404s for some static files, and the UI looked a little weird.
So overall woot! It's a bit slow to launch now because it has to setup the postgres stuff each time, but I think we can figure that out later.
@cdrini I thought I'd fixed the js issues and UI weirdness, I'll take another look tomorrow and see if I can figure out what has been missed.
If you have any thoughts on how to speed up the postgres start, that'd be super helpful too! Based on something you said, I was putting that down to a Xenial issue, rather than containers, but I haven't been able to find any obvious cause.
@cdrini, I've made changes per your comments. I tried running everything from a clean checkout and could not reproduce the js 404s. I did rebase, so if it was an unrelated code change that has since been fixed, it may be resolved? Could you get this updated branch and see if you are still getting those errors? I found that the local OL can get confused with exisiting cookies which can break the nav bar and logged in info. Using an incognito window is a quick way to check if that's the problem with UI display.
Any other comments?
I got it running, but I'm still having the same issue with static files :/ Interestingly enough, I can access file in
Ok, it looks like that static issues are because of symlinks on Windows. I think it's related to this: docker/for-win#109 . In the interest of progress, let's move forward though. I'll create an issue for further investigating this.
- Add a link to the issue about symlinks: #1051
- Could you
fixupsome of the commits that don't really make sense anymore? There' no need to keep some of those "fix typo"/"revert X"/etc commits hanging around.