New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake8 error on build #1326

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@hornc
Collaborator

hornc commented Oct 12, 2018

fixes #1324

@hornc hornc merged commit c7c99f4 into master Oct 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hornc hornc deleted the devfix/flake8 branch Oct 12, 2018

@mekarpeles

This comment has been minimized.

Member

mekarpeles commented Oct 12, 2018

I feel like in some ways this is also a regression as linting is no longer happening during travis (?)

We may want to open a followup issue to make sure lint makes it back in as an option and that we include flake8 aas a dependency

@mekarpeles

This comment has been minimized.

Member

mekarpeles commented Oct 12, 2018

p.s. thank you for unblocking our community as I agree w/ your decision: empowering developers = top priorty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment