Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker/readme to include setup instructions on Windows #1697

Merged
merged 2 commits into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@dnguneratne
Copy link
Contributor

commented Dec 8, 2018

Updates docker/readme file using PR #1404 to include Windows specific instructions when using Docker.

Closes #1696

@mekarpeles
Copy link
Member

left a comment

1 suggestion re: Rm references to vagrant. I'd personally separate style changes such as * to - to a different PR in the future but I'm fine with this case.

Show resolved Hide resolved docker/README.md Outdated
@mekarpeles

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

P.s. thank you for submitting this PR!!

@mekarpeles mekarpeles merged commit 88d3af9 into internetarchive:master Dec 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mekarpeles

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

🎉

@cdrini

This comment has been minimized.

Copy link
Collaborator

commented Dec 9, 2018

Nice! My comments would be you could probably also remove the #TODO at the bottom of the page (since the new instructions fix that issue :) ), and agree with Mek that formatting/style stuff should be in a separate PR. Not a huge issue here because the PR is so small, but small, specific PRs make it much easier for lazy developers like myself people to code review things :)

@dnguneratne dnguneratne deleted the dnguneratne:issue-1696 branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.