Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Start testing on Python 3.7 #1774

Merged
merged 6 commits into from Feb 19, 2019
Merged

Travis CI: Start testing on Python 3.7 #1774

merged 6 commits into from Feb 19, 2019

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Dec 28, 2018

Description: What does this PR achieve? [feature|hotfix|refactor]

Upgrade Travis runtime from Trusty to Xenial https://blog.travis-ci.com/2018-11-08-xenial-release and upgrade Python from 3.6 to 3.7.

Technical: What should be noted about the implementation?

Testing: Steps for reviewer to reproduce / verify this PR fixes the problem?

Evidence: If this PR touches UI, please post evidence (screenshot) of it behaving correctly:

@tfmorris
Copy link
Contributor

Does this add Xenial testing or swap Xenial for Trusty? I should probably know the answer, but I can't easily tell from the Travis docs or the edits.

Our production stack is still on Trusty, as I understand it, so I think it's important to keep testing. The Docker environment runs Xenial and we want to move production to that too, so it is valuable to start testing on it, but not at the expense of Trusty -- plus, my reading of the Travis docs is that Xenial support isn't fully baked for another month or two.

@cclauss
Copy link
Collaborator Author

cclauss commented Dec 29, 2018

Before it was swapping out Trusty for all runs because the blog post above says that Xenial is production-ready but not the default. This commit runs Python 2.7 and 3.6 on Trusty and 3.7 on Xenial in accordance with travis-ci/travis-ci#9069

@cclauss cclauss changed the title Travis CI: Start testing on Xenial and Python 3.7 Travis CI: Start testing on Python 3.7 Dec 29, 2018
@tfmorris
Copy link
Contributor

I've resolved the merge conflict in the simplest way possible. We can probably just use PyYAML 4.2b4 for all versions of Python, but didn't have a chance to test.

With that resolved and the addition of both Trusty & Xenial to the matrix LGTM.

Copy link
Collaborator

@hornc hornc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cclauss
Copy link
Collaborator Author

cclauss commented Feb 19, 2019

@tfmorris Is there something more to do on this one?

@mekarpeles
Copy link
Member

lgtm

@mekarpeles mekarpeles merged commit 1c47721 into internetarchive:master Feb 19, 2019
@cclauss cclauss deleted the patch-1 branch February 19, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants