Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing amz isbn lookup to use ImportBot #1960

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@mekarpeles
Copy link
Member

mekarpeles commented Mar 8, 2019

Description: What does this PR achieve? [feature|hotfix|refactor]

closes #1783 and closes #1461, relates to #1457

@mekarpeles mekarpeles requested a review from hornc Mar 8, 2019

@@ -477,7 +477,7 @@ def GET(self):

self.redirect_if_needed(i)

if 'isbn' in i and all(not v for k, v in i.items() if k != 'isbn'):
if 'isbn' in i:

This comment has been minimized.

Copy link
@mekarpeles

mekarpeles Mar 8, 2019

Author Member

This fixes search (if isbn is present, redirects gracefully, even if multiple other query params present)

@hornc

hornc approved these changes Mar 8, 2019

Copy link
Collaborator

hornc left a comment

LGTM!

@mekarpeles mekarpeles merged commit c0e48d8 into master Mar 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mekarpeles mekarpeles deleted the refactor/isbn-api branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.