-
Notifications
You must be signed in to change notification settings - Fork 42
"Same website on IPv6 and IPv4" test should not be required #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Easy test site: ip.tyk.nu @baknu as part of this, I have added the use of |
So this means that the website test gets a bit more relaxed (or less strict) in general. Although I believe it affects just a few websites, I can see the point. I would suggest to give a "warning" and not an "informational" instead of the current "bad", because in most cases the difference will not be intended and should be fixed by the website owner. Note that both a "warning" and an "informational" do not impact the %-score. Might be something to discuss with the steering group. |
Adjustments based on discussion:
1 and 2 should be FAIL (❌), 3 should be NOTICE ( |
The new behaviour is now implemented in #1039. We need to make content for the new label |
@mxsasha Have you added this text label somehwere in the content repo? Or shall I add it to the content branch "version-1.8" under detail/web/ipv6/web-ipv46/verdict? |
I did not create it in branch yet, so yes, please create it. |
@mxsasha Ok, done. Also edited the test explanation and the "bad" verdicts. Could you review? Thanks. |
Looks good! |
Currently, internet.nl gives an error if the IPv6 and IPv4 versions of a website are different. However, this is not useful for an IPv6-only website whose "IPv4 version" just says something like "You need to enable IPv6 to view this website" and has no actual content (e.g. earthite.com). Instead, this subtest should only be made a warning, in order to still catch IPv6-related misconfigurations, but not to disqualify websites that may have a legitimate reason to have different content on IPv6 and IPv4.
The text was updated successfully, but these errors were encountered: