Skip to content

Add Sentry reporting for exceptions on production instance #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mxsasha opened this issue Oct 20, 2022 · 2 comments
Closed

Add Sentry reporting for exceptions on production instance #770

mxsasha opened this issue Oct 20, 2022 · 2 comments
Assignees
@mxsasha
Labels
infrastructure-docker
Milestone
v1.7

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Oct 20, 2022

We've been discussing this for a while - we don't have any active error reporting in production, and are probably missing things. Adding Sentry is probably our best method for this. We do need to look closely at what information they'd receive.
@mxsasha mxsasha added this to the v1.7 milestone Oct 20, 2022
@mxsasha mxsasha self-assigned this Oct 20, 2022
@mxsasha mxsasha mentioned this issue Oct 20, 2022
Closed
@mxsasha mxsasha mentioned this issue Nov 8, 2022
Closed
@baknu
Copy link
Contributor

baknu commented Nov 8, 2022

We might also want to ask Prolo if they could provide us with Logstash (instead of using an external service like Sentry).

@mxsasha
Copy link
Collaborator Author

mxsasha commented Nov 9, 2022

Logstash is a rather different product. Sentry can be self-hosted too though.

@mxsasha mxsasha mentioned this issue Nov 10, 2022
Merged
mxsasha added a commit that referenced this issue Nov 10, 2022
@mxsasha
Fix #769 - Correctly indicate probe error to user (#802)
10ec9b0 
Before this change, the only check was whether a test was complete,
not whether it was at all successful. After redirect to the result
page, we then presented the most recent result for each probe,
which could silently return results from the distant past.

There may still be some cases where test error handling is not optimal,
but those should be loud, which means #770 will notify us.
mxsasha added a commit that referenced this issue Dec 13, 2022
@mxsasha
[1.6.x] Fix #769 - Correctly indicate probe error to user (#802)
66abd12 
Before this change, the only check was whether a test was complete,
not whether it was at all successful. After redirect to the result
page, we then presented the most recent result for each probe,
which could silently return results from the distant past.

There may still be some cases where test error handling is not optimal,
but those should be loud, which means #770 will notify us.

(cherry picked from commit 10ec9b0)
mxsasha added a commit that referenced this issue Dec 20, 2022
@mxsasha
[1.6.x] Fix #769 - Correctly indicate probe error to user (#802)
0ce0690 
Before this change, the only check was whether a test was complete,
not whether it was at all successful. After redirect to the result
page, we then presented the most recent result for each probe,
which could silently return results from the distant past.

There may still be some cases where test error handling is not optimal,
but those should be loud, which means #770 will notify us.

(cherry picked from commit 10ec9b0)
mxsasha added a commit that referenced this issue Feb 9, 2023
@mxsasha
Fix #770 - Add Sentry support
2585447 
See #861 for more comments on PII removal.
@mxsasha mxsasha closed this as completed in 1a15c19 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxsasha mxsasha

Labels
infrastructure-docker
Milestone
v1.7
Development

No branches or pull requests
2 participants
@mxsasha @baknu