Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader change made some meshes invisible #9

Closed
NetherNarwhal opened this issue Nov 25, 2018 · 4 comments
Closed

Shader change made some meshes invisible #9

NetherNarwhal opened this issue Nov 25, 2018 · 4 comments

Comments

@NetherNarwhal
Copy link
Contributor

I haven't tracked down the issue yet, but something in the "Texture atlases can specify a shader by name" change caused many models not to show up (collision boxes are still there) with the retail assets. In the tutorial map, the tombstone in the secret area and the bridge are invisible. In the campsite, it's tents, the well, tombstones, tables, etc. that are invisible.

I reverted that change and they all showed up again. There aren't any warnings in the logs that I see. I'm running on Linux.

@Interrupt
Copy link
Owner

Interrupt commented Nov 25, 2018

I'm not seeing this issue myself, but it's probably related to a few of the changes in GLRenderer. Could I enlist you in trying to fix this since you have a reproducible case?

Here's the diff:
bf87249#diff-3d8307cdb45dfddb49eb901df6f79388L955

Look for the // draw static mesh batches near the old line 956 in GlRenderer.java - does adding the worldShaderInfo.begin(); and worldShaderInfo.end(); lines around that static mesh rendering block fix things if you add them back in?

@NetherNarwhal
Copy link
Contributor Author

Yep, that looks like it fixed it.

@vibrantrida
Copy link
Contributor

That fixed the issue for me too.

@Interrupt
Copy link
Owner

Thanks for verifying, pushed a fix in 44c1e53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants