Unreported error from `npm run build` on dev mode activation

[isc-tleavitt]

Output from "git-source-control activate" includes:

In developer mode, building web UI:
npm ci
1
npm run build
-4058

@isc-etamarch do you see this too? This could explain why your changes on #608 didn't propagate to release.

Good things to do here:

• Capture and repeat log output from npm ci / npm run build in IPM verbose mode
• Fail the <Invoke> if we're in dev mode, npm ci succeeds, and npm run build fails. (This specific combination of events is important, because installing via zpm "load https://github.com/intersystems/git-source-control" will install in dev mode and we won't necessarily have npm available.)

[isc-tleavitt]

Interestingly, CI output includes:

npm ci
bash: line 1: npm: command not found
127
npm run build
bash: line 1: npm: command not found
127

So we're reporting some level of errors here, it seems, maybe just not capturing STDOUT?

[isc-tleavitt]

... and on a Linux environment, I just got:

In developer mode, building web UI:
npm ci
npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
...
0
npm run build

> git-webui@1.3.0 build
> grunt release

Running "copy:jquery" (copy) task
Copied 1 file

Running "copy:bootstrapjs" (copy) task
Copied 1 file

Running "copy:bootstrapcss" (copy) task
Copied 1 file

Running "copy:popperjs" (copy) task
Copied 1 file

Running "copy:git_webui" (copy) task
Created 7 directories, copied 23 files

Running "less:files" (less) task
>> 1 stylesheet created.

Running "copy:release" (copy) task
Created 7 directories, copied 28 files

Done.
0
[USER|git-source-control]       Compile SUCCESS

[isc-tleavitt]

This was 100% me doing something dumb in my environment.