-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint to access user notifications observed by virtual user #21
Open
BenjaminPelletier
wants to merge
21
commits into
interuss:main
Choose a base branch
from
BenjaminPelletier:user_notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add endpoint to access user notifications observed by virtual user #21
BenjaminPelletier
wants to merge
21
commits into
interuss:main
from
BenjaminPelletier:user_notifications
+93
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essible through an endpoint
…ht_id as directed during interuss discussion
Co-authored-by: Michael Barroco <michael@orbitalize.com>
Co-authored-by: Michael Barroco <michael@orbitalize.com>
Co-authored-by: Michael Barroco <michael@orbitalize.com>
… to a generic user notification
Co-authored-by: Michael Barroco <michael@orbitalize.com>
barroco
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work in #19 while shifting focus to the subject of the flight_planning API (virtual user).
Additional changes beyond #19's framework for setting up the user_notifications RESTful resource include:
interuss.flight_planning.plan
conflict_count
since we separately are able to distinguish between unknown, 0, 1, and more than 1 conflicts and I'm not sure where (what kind of test) we would need to useconflict_count
in addition to theconflicts
enum (but we can add this back if we can identify a test like that and the requirement(s) it would be verifying)