[uss_qualifier] endpoint_encryption: use requests exceptions #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
reviewed
Jun 2, 2025
Comment on lines
+86
to
+89
| except requests.exceptions.ConnectionError: | ||
| pass | ||
| except requests.exceptions.Timeout: | ||
| pass |
Contributor
There was a problem hiding this comment.
Nit: we could do
except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
pass
(esp given other exceptions might get added later :))
Shastick
approved these changes
Jun 2, 2025
Contributor
Shastick
left a comment
Shastick
left a comment
There was a problem hiding this comment.
Looks good, see minor nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad recorded in #1033, it does seems that
errnois not set on the connection error from the requests libraryThis PR use the errors from the library in addition to the standard ones.