[uss_qualifier] make PlanningAreaResource a non-standard-specific resource #1048
Conversation
Shastick
force-pushed
the
fix-move-planning-area-resources
branch
4 times, most recently
from
ac1c57f to
56587be
Compare
Shastick
force-pushed
the
fix-move-planning-area-resources
branch
from
56587be to
318bb89
Compare
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
LGTM modulo minor comments.
| utm_client_identity: {$ref: 'library/resources.yaml#/utm_client_identity'} | ||
| id_generator: {$ref: 'library/resources.yaml#/id_generator'} | ||
| kentland_service_area: {$ref: 'library/resources.yaml#/kentland_service_area'} | ||
| kentland_planning_area: {$ref: 'library/resources.yaml#/kentland_planning_area'} |
There was a problem hiding this comment.
Changes in this file look unintended?
| utm_client_identity: {$ref: 'library/resources.yaml#/utm_client_identity'} | ||
| id_generator: {$ref: 'library/resources.yaml#/id_generator'} | ||
| kentland_service_area: {$ref: 'library/resources.yaml#/kentland_service_area'} | ||
| kentland_planning_area: {$ref: 'library/resources.yaml#/kentland_planning_area'} |
There was a problem hiding this comment.
Changes in this file look unintended?
Shastick
force-pushed
the
fix-move-planning-area-resources
branch
from
318bb89 to
f626936
Compare
|
Since this change will break customers' test configurations unless they update |
|
Oh my, that's an important oversight. I'll quickly prepare a PR that adds something back at |
|
@BenjaminPelletier here is a first fix. I'm not versed enough in Python to know if there's a better way, but for the moment it allows importing the resource via the old path and will trigger a warning in that situation. |
@BenjaminPelletier My bad! I did not consider that part, I will keep that in mind for future reviews. |
3 participants
This is a preparatory step towards re-using the PlanningAreaResource for f3411 scenarios (eg in #1041).
It is moved from to
monitoring/uss_qualifier/resources/astm/f3548/v21/planning_area.pytomonitoring/uss_qualifier/resources/planning_area.py.All other changes are adaptations of import paths.