-
Notifications
You must be signed in to change notification settings - Fork 28
[uss_qualifier] Add datastore unit tests #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mickmis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really great, thanks!
I used a custom image that I build for cockroachdb with tls 1.1 support, I didn't find old images (2017..). I suppose we want to upload that on the official interuss account?
Indeed. And actually I'd go as far as uploading all images used in this test in the interuss Docker Hub repo. WDYT @BenjaminPelletier ? We would need you to do so :)
But that should not prevent this PR from going in IMO.
| { url = "https://files.pythonhosted.org/packages/4e/8c/f3147f5c4b73e7550fe5f9352eaa956ae838d5c51eb58e7a25b9f3e2643b/decorator-5.2.1-py3-none-any.whl", hash = "sha256:d316bb415a2d9e2d2b3abcc4084c6502fc09240e292cd76a76afc106a1c8e04a", size = 9190, upload-time = "2025-02-24T04:41:32.565Z" }, | ||
| ] | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this prevent the project from being run on some OSs? Or is it transparent whether we are on Linux, MacOS or Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, shouldn't this be added as a dev dependency to avoid users having to depend on this?
(or maybe it is already the case and I did not notice it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that a dev dependency, I added in the wrong group ^^'
For OS that should be transparent*, and in all cases unit tests run in a controller environment in a docker container by default, so that shouldn't interfere :)
- As long as we can start docker containers ^^'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't have a dev group yet, but there are other things that should go into that 'group', I suggest we postpone the fix in a future PR, with two separate groups and two image, one for 'tooling' and a light one with only running dependencies installed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@the-glu SGTM, if you don't do it in the short-term, could you open an issue about it?
I would expect us to follow whatever we document for users for the other images. We could consider mirroring images of the specifically-supported underlying database technologies via the interuss Docker org, but that would be a separate discussion. Until we decide otherwise, I think our standard procedure has our users use the original images so we should use those also. |
|
FTR: #1094 has been merged while it contained the commits present in this PR. This PR now contains only the fixes that happened in between: change in uv.lock and use of |
Add datastore unit tests to ensure various
DatastoreDBNodeworks against real database.Database are spawn using testcontainer, I added DiD support to start thoses containers.
I fixed
is_reachablefor yugabyte that require hashed password in some cases.I used a custom image that I build for cockroachdb with tls 1.1 support, I didn't find old images (2017..). I suppose we want to upload that on the official interuss account?