Skip to content

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Sep 3, 2025

It's not possible to run a test case multiple time, so the fix (based on the comment) to attributes queries correctly by running the test case for each observer is not valid.

This PR only prevent a crash with multiple observers and probably create attribution issues, so we probably want at least an issue or to fix it there.

@Shastick any opinion ?

@Shastick
Copy link
Contributor

Shastick commented Sep 3, 2025

This PR only prevent a crash with multiple observers and probably create attribution issues, so we probably want at least an issue or to fix it there.

Where do you think we would have attribution issues? As long as failed checks are properly attributed we should be fine? Possibly, we could add some details in the scenario documentation stating something along the line "For this test cases, these steps will be run once per observer", and possibly name said steps in a distinct manner (we do this for dss_interoperability).

@the-glu
Copy link
Contributor Author

the-glu commented Sep 3, 2025

Where do you think we would have attribution issues? As long as failed checks are properly attributed we should be fine?

Because it's in the removed comment ^^'

       # (Otherwise we can't differentiate which queries are from which observer)

@Shastick
Copy link
Contributor

Shastick commented Sep 3, 2025

Ah, yes. I still think that if we take care to run the steps for each observer sequentially things should be fine? As far as I understand this PR, it is only changing when we call "begin_test_case()", not how/which steps are executed, ie, the for-loop's logic is untouched, except for keeping track of the start-time: we should put that back into the loop?

@barroco barroco merged commit dbaa810 into interuss:main Sep 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants