Do not respond to every method with suffix #104

Merged
merged 2 commits into from Mar 30, 2014

Conversation

Projects
None yet
3 participants
@Maxim-Filimonov
Contributor

Maxim-Filimonov commented Jul 21, 2013

Resolves intridea/hashie#89. Does not break any tests but not sure how does it affect dependent libraries like grape.

@dblock dblock merged commit a21eea9 into intridea:master Mar 30, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Mar 30, 2014

Contributor

I'm taking over this project, this has been merged. Thanks for contributing!

Contributor

dblock commented Mar 30, 2014

I'm taking over this project, this has been merged. Thanks for contributing!

@7even

This comment has been minimized.

Show comment
Hide comment
@7even

7even Apr 29, 2014

Contributor

If a mash successfully processes methods like #wrong_key_ via method_missing, shouldn't mash.respond_to?(:wrong_key_) return true? This just broke my gem.

Contributor

7even commented Apr 29, 2014

If a mash successfully processes methods like #wrong_key_ via method_missing, shouldn't mash.respond_to?(:wrong_key_) return true? This just broke my gem.

7even added a commit to roomink/settings that referenced this pull request Apr 29, 2014

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Apr 29, 2014

Contributor

@7even Yes. Can you please PR a fix/open a bug?

Contributor

dblock commented Apr 29, 2014

@7even Yes. Can you please PR a fix/open a bug?

@7even

This comment has been minimized.

Show comment
Hide comment
@7even

7even Apr 29, 2014

Contributor

Well, it was me who initially brought this functionality to hashie, now I'd suggest reverting this pull request (so a mash responds to unknown keys again) and submitting a patch to ActiveModel::ForbiddenAttributesProtection but I'm not sure how to fix the latter.

Contributor

7even commented Apr 29, 2014

Well, it was me who initially brought this functionality to hashie, now I'd suggest reverting this pull request (so a mash responds to unknown keys again) and submitting a patch to ActiveModel::ForbiddenAttributesProtection but I'm not sure how to fix the latter.

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Apr 29, 2014

Contributor

Ok, either way open a new issue here re-describing the problem we have now. I'll think about it and we should have other people comment.

Contributor

dblock commented Apr 29, 2014

Ok, either way open a new issue here re-describing the problem we have now. I'll think about it and we should have other people comment.

@7even

This comment has been minimized.

Show comment
Hide comment
@7even

7even Apr 30, 2014

Contributor

Done.

Contributor

7even commented Apr 30, 2014

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment