GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves intridea/hashie#89. Does not break any tests but not sure how does it affect dependent libraries like grape.
Do not respond to suffixes for keys which are not present in mash. Fi…
…xes compability with activesupport permit?
Reuse suffixes constant for method missing suffixes search
I'm taking over this project, this has been merged. Thanks for contributing!
If a mash successfully processes methods like #wrong_key_ via method_missing, shouldn't mash.respond_to?(:wrong_key_) return true? This just broke my gem.
fix after intridea/hashie#104
@7even Yes. Can you please PR a fix/open a bug?
Well, it was me who initially brought this functionality to hashie, now I'd suggest reverting this pull request (so a mash responds to unknown keys again) and submitting a patch to ActiveModel::ForbiddenAttributesProtection but I'm not sure how to fix the latter.
Ok, either way open a new issue here re-describing the problem we have now. I'll think about it and we should have other people comment.