Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes Issue #106: deep_merge recursively slow #107
The call to custom_writer within deep_merge was exponentially converting the values (unnecessarily, since they were just converted within deep_merge). Added an optional param to custom_writer to suppress the conversion. Unfortunately, had to also add the param to coercion's customer_writer method as well (which is just ignored) to not break the inheritance.
All tests pass.
I was just made aware of this issue via @johnae's comment on #106. Thankfully I haven't had any massive performance issues myself, but I'll probably switch for your fork for good measure till this is merged in.
@davemitchell, I'd suggest maybe adding a test or two to ensure the behavior doesn't return further down the road. Specially since it's not exactly the most obvious of issues like a syntax error or something else silly.
referenced this pull request
Oct 24, 2013
added a commit
this pull request
Oct 25, 2013
@dblock lol, my timing... nice job. :-)