Global options have priority over adapter options and defaults #96

Merged
merged 1 commit into from Mar 8, 2013

Projects

None yet

2 participants

@rwz
Member
rwz commented Mar 8, 2013

I thought that if we decide to bring back quirks_mode as a default in json_{gem,pure} adapters, the first that user will try to do to cancel it would be something like this:

MultiJson.load_options = MultiJson.dump_options = { quirks_mode: false }

And that will not work as expected because adapter-specific options (with quirks_mode enabled by default) have bigger priority.

That pull-request changes that and put global options over adapter-specific and defaults.

@coveralls

Coverage increased (+0.0%) when pulling e4ff581 on global-over-local into 80e86f4 on master.

View Details

@rwz rwz merged commit 0f4ab19 into master Mar 8, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment