Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on May 25, 2015
  1. @sferik
  2. @sferik
  3. @sferik

    Delete guard

    sferik authored
  4. @sferik
Commits on Feb 27, 2015
  1. @mbleigh

    Merge pull request #795 from tomhughes/fail-origin

    mbleigh authored
    Set origin when mocking a failure
Commits on Feb 21, 2015
  1. @tomhughes
Commits on Dec 25, 2014
  1. @tmilewski

    Merge pull request #783 from intridea/travis-ruby-22

    tmilewski authored
    Adding Ruby 2.2 to the Travis CI test matrix
  2. @tmilewski
  3. @tmilewski

    Merge pull request #784 from intridea/rubocop-0.28.0

    tmilewski authored
    Update to Rubocop 0.28.0
  4. @tmilewski

    Update to Rubocop 0.28.0

    tmilewski authored
Commits on Oct 9, 2014
  1. @sferik
Commits on Oct 1, 2014
  1. @mbleigh

    Merge pull request #774 from schneems/schneems/memoize-omniauth

    mbleigh authored
    Minimize object creation on middleware call.
  2. @schneems

    Minimize object creation on middleware call.

    schneems authored
    This patch isn't nearly as invasive as #773. Also it was tested against itself, not in a full Rails app. I'm contributing the perf scripts I wrote in another PR.
    
    Notice that by memorizing methods, not only are we reducing objects created in omniauth, but also in hashie due to fewer method calls to various omniauth options.
    
    
    ## Bench
    
    Before patch
    
    ```
    Calculating -------------------------------------
                     ips       470 i/100ms
    -------------------------------------------------
                     ips     4877.1 (±10.1%) i/s -      24440 in   5.061663s
    2.1.2  ~/documents/projects/omniauth (master)
    $ be rake perf:ips
    Calculating -------------------------------------
                     ips       467 i/100ms
    -------------------------------------------------
                     ips     4840.9 (±14.5%) i/s -      23817 in   5.068649s
    2.1.2  ~/documents/projects/omniauth (master)
    $ be rake perf:ips
    Calculating -------------------------------------
                     ips       465 i/100ms
    -------------------------------------------------
                     ips     4799.5 (±11.8%) i/s -      23715 in   5.019191s
    ```
    
    After Patch
    
    ```
    $ be rake perf:ips
    Calculating -------------------------------------
                     ips       631 i/100ms
    -------------------------------------------------
                     ips     6269.1 (±11.8%) i/s -      30919 in   5.014849s
    2.1.2  ~/documents/projects/omniauth (master)
    $ be rake perf:ips
    Calculating -------------------------------------
                     ips       615 i/100ms
    -------------------------------------------------
                     ips     6207.8 (±10.3%) i/s -      31365 in   5.106172s
    2.1.2  ~/documents/projects/omniauth (master)
    $ be rake perf:ips
    Calculating -------------------------------------
                     ips       522 i/100ms
    -------------------------------------------------
                     ips     6155.8 (±9.3%) i/s -      30798 in   5.048455s
    ```
    
    
    
    ## Memory Bench
    
    100 requests without patch
    
    
    ```
    allocated objects by gem
    -----------------------------------
    hashie-3.3.1 x 6901
    rack-1.5.2 x 5300
    omniauth/lib x 3637 <====================
    ruby-2.1.2/lib x 301
    other x 300
    ```
    
    100 requests with patch 
    
    ```
    allocated objects by gem
    -----------------------------------
    rack-1.5.2 x 4800
    hashie-3.3.1 x 4701
    omniauth/lib x 1037 <====================
    ruby-2.1.2/lib x 301
    other x 300
    ```
    
    Results in `(3637  - 1037 )/ 3637.0 * 100  # => 71 %` less objects.
  3. @mbleigh
Commits on Aug 21, 2014
  1. @sferik
Commits on Aug 18, 2014
  1. @sferik
Commits on Jul 22, 2014
  1. @sferik
Commits on Jul 9, 2014
  1. @sferik

    Bump version to 1.2.2

    sferik authored
  2. @sferik
  3. @sferik
Commits on Jun 11, 2014
  1. @tmilewski

    Merge pull request #750 from intridea/rubocop

    tmilewski authored
    Update RuboCop to >=0.23
  2. @tmilewski

    Update RuboCop to >=0.23

    tmilewski authored
  3. @tmilewski

    Merge pull request #748 from matthewrudy/hashie-3.0

    tmilewski authored
    Hashie 3.0.0
  4. @matthewrudy
Commits on Jun 10, 2014
  1. @tmilewski
Commits on Jun 3, 2014
  1. @petergoldstein
  2. @petergoldstein
Commits on May 30, 2014
  1. @tmilewski
  2. @tmilewski
  3. @tmilewski
Commits on Mar 15, 2014
  1. @sferik
  2. @sferik
Commits on Mar 6, 2014
  1. @sferik

    Stop signing gem [ci skip]

    sferik authored
Commits on Mar 2, 2014
  1. @sferik
Commits on Feb 12, 2014
  1. @sferik
Something went wrong with that request. Please try again.