Skip to content
This repository

"/auth/:provider" path doesn't pass through to app in test mode. #152

Closed
chanks opened this Issue January 18, 2011 · 3 comments

3 participants

Chris Hanks Irina Dumitrascu Michael Bleigh
Chris Hanks

I'm relying on the /auth/:provider path hitting my app before it redirects, so I can store information from the query string in the session (as recommended by mbleigh in pull request #123: #123 (comment)).

When omniauth is in test mode, however, it simply redirects "/auth/:provider" directly to "/auth/:provider/callback" without hitting the app, so I'm not able to test my app's behavior.

Thanks!

Irina Dumitrascu

I have a related problem, it looks that the OAuth2 strategy does not hit the application at all in the request phase: https://github.com/intridea/omniauth/blob/master/oa-oauth/lib/omniauth/strategies/oauth2.rb#L57

Is this by design or would you welcome a patch for calling the app before redirecting to the provider?

Thank you.

Michael Bleigh
Owner

I would welcome the patch. That was an oversight in building the test mode.

Michael Bleigh
Owner

Call thru to app in mock request_phase. Closed by 61e64c3

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.