Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Strategy #673

Closed
dereke opened this issue Mar 23, 2013 · 0 comments
Closed

Developer Strategy #673

dereke opened this issue Mar 23, 2013 · 0 comments

Comments

@dereke
Copy link

dereke commented Mar 23, 2013

When I use the developer strategy (only in development mode of course!) and I hit /auth/developer the response type is set to text/plain rather than text/html.

I notice the offending line is here https://github.com/intridea/omniauth/blob/master/lib/omniauth/form.rb#L186

I believe this would be better:
Rack::Response.new(@html, 200, {'content-type' => 'text/html'}).finish

Is there any reason why text/plain would be preferred or should I make a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant