Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubinius specs, remove failing Ruby 1.8 specs #713

Closed
wants to merge 3 commits into from
Closed

Fix Rubinius specs, remove failing Ruby 1.8 specs #713

wants to merge 3 commits into from

Conversation

petergoldstein
Copy link
Contributor

  1. Added the Rubinius gems to the Gemfiles
  2. Updated the Travis CI rbx VM labels
  3. Removed failing 1.8 VMs - mime-types 2.0 requires Ruby 1.9 or greater

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling d564a17 on petergoldstein:feature/fix_rbx into 7c97b20 on intridea:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 165918f on petergoldstein:feature/fix_rbx into 7c97b20 on intridea:master.

@tmilewski
Copy link
Member

Thanks a lot!

@mbleigh @sferik How do you guys feel about dropping support for 1.8 at this point, considering the requirements for mime-types 2.0?

@sferik
Copy link
Contributor

sferik commented Dec 26, 2013

The mime-types dependency is not a good reason to drop Ruby 1.8 support, since it’s only a development dependency and version 1.25 works like a charm. The Ruby Core Team, in partnership with Heroku, recently announced that they’d be maintaining Ruby 1.8.7 for another 6 months (at least). That indicates to me that a significant number of Heroku customers are still using it, so I think we should try to support it here, if possible.

sferik added a commit that referenced this pull request Dec 26, 2013
sferik added a commit that referenced this pull request Dec 26, 2013
@sferik sferik closed this in a35c2cd Dec 26, 2013
@petergoldstein petergoldstein deleted the feature/fix_rbx branch December 26, 2013 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants