Skip to content

Fixes #10

Open
wants to merge 52 commits into from

6 participants

@kristianmandrup

No description provided.

iffyuva and others added some commits Jul 28, 2012
@iffyuva iffyuva remove twitter gemspec and add social buttons gemspec 5f43edb
@iffyuva iffyuva add like button 8a5c9e0
@iffyuva iffyuva refactor tweet and like buttons code 92292e6
@iffyuva iffyuva update gemspec e1ea2e0
@iffyuva iffyuva add support for pinit button 05d3968
@iffyuva iffyuva add more details to readme dc2b715
@iffyuva iffyuva remove author names from the top 976a3d8
@kristianmandrup kristianmandrup lots of cool new features, dsl and refactoring - updated README to re…
…flect changes
702309b
@kristianmandrup kristianmandrup bump version f09267c
@kristianmandrup kristianmandrup specs pass c35490b
@kristianmandrup kristianmandrup specs infra ok b208582
@kristianmandrup kristianmandrup fresh gemspec e85e594
@kristianmandrup kristianmandrup Merge pull request #1 from kristianmandrup/master
Lots of cool new features, config DSL etc.
6b91475
@kristianmandrup kristianmandrup added config specs pass d8cadec
@kristianmandrup kristianmandrup Merge pull request #2 from kristianmandrup/master
Added config DSL specs :)
dd1bd66
@kristianmandrup kristianmandrup bump version bd7831e
@kristianmandrup kristianmandrup Merge pull request #3 from kristianmandrup/master
A lot of nice refactorings to make it a whole lot better... also added Google+ button support :)
1e4d93a
@kristianmandrup kristianmandrup updated README 9675ff0
@kristianmandrup kristianmandrup Regenerate gemspec for version 0.3.5 4f65ccb
@kristianmandrup kristianmandrup README install fix 5d283b8
@kristianmandrup kristianmandrup refactored script logic and fixed widgetized bug 0014076
@kristianmandrup kristianmandrup Regenerate gemspec for version 0.3.6 3cdfd27
@iffyuva iffyuva remove init.rb 5e77b80
@iffyuva iffyuva add social-buttons.rb for automatic loading of railtie ff89740
@iffyuva iffyuva regenerate gemspec 70fefe7
@iffyuva iffyuva url is not accessible for twitter, parameterize it 0988666
@kristianmandrup kristianmandrup Merge branch 'master' of github.com:iffyuva/social-buttons fdb0b5b
@kristianmandrup kristianmandrup Merge branch 'minor-fixes' of github.com:iffyuva/social-buttons cc588c4
@kristianmandrup kristianmandrup merged fixes and fixed tweet spec to pass 1fd0fec
@kristianmandrup kristianmandrup bump version 815d962
@kristianmandrup kristianmandrup Regenerate gemspec for version 0.3.7 7d0ef2c
@yosiyuki yosiyuki merge upstream 47a336b
@yosiyuki yosiyuki Merge branch 'master' of git://github.com/kristianmandrup/social-buttons 80accae
@yosiyuki yosiyuki change facebook like tag to html5 valid style 0784593
@yosiyuki yosiyuki upgrade version 72bf31e
@yosiyuki yosiyuki update version 8bb0f28
@kristianmandrup kristianmandrup Merge pull request #1 from yosiyuki/master
avoiding invalid html for facebook like javascript tag
607ff6d
@dalezak dalezak Changed Twitter widget url from http to https 0efed28
@kristianmandrup kristianmandrup Merge pull request #10 from dalezak/master
Changed Twitter widget url from http to https
1b44a56
@artemasmith artemasmith locale choise added b0fd3e6
@artemasmith artemasmith add facebook locale choise ability. Fix bug with cant load social_but…
…tons/railtie. Test added
3537fa9
@artemasmith artemasmith google button fixed script issue ef2c9d9
@artemasmith artemasmith google async script load fixed 1780fa1
@artemasmith artemasmith vkontakte added 47c4b9f
@artemasmith artemasmith before pull request 5c35f6c
@artemasmith artemasmith unnesesary code deleted eca56b9
@dalezak dalezak Changed Twitter widget url from http to https 3a9d8fb
@iffyuva iffyuva Merge pull request #12 from artemasmith/master
I'm not a contributor. Tests passed.
6a8ccfc
@kirtithorat kirtithorat Fixed the tweet_button example
The following tweet_button example will give Syntax error
<%= tweet_button(via: => "peterc", url: "http://news.ycombinator.com", :text => "AWESOME.") %> 

The issue is with following
via: => "peterc" 
The hash is not defined correctly. It should be either 
via: "peterc" 
or 
:via => "peterc"
4ada053
@iffyuva iffyuva Merge pull request #13 from kirtithorat/master
Fixed the tweet_button example
02a5c3e
@iffyuva iffyuva Regenerate gemspec for version 0.3.9 0c33e90
@iffyuva iffyuva remove generated social-buttons 0.3.8 version 9784394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.