Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle plugin should not throw an error if a version is not found #1276

Closed
rbellamy opened this issue Jun 3, 2020 · 4 comments
Closed

gradle plugin should not throw an error if a version is not found #1276

rbellamy opened this issue Jun 3, 2020 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@rbellamy
Copy link
Contributor

rbellamy commented Jun 3, 2020

Describe the bug

If there is no version property found, the gradle plugin throws an error.

To Reproduce

throw new Error("No version was found in gradle properties.");

test("should throw when no version", async () => {
exec.mockReturnValueOnce("");
await expect(hooks.getPreviousVersion.promise()).rejects.toThrowError(
"No version was found in gradle properties."
);
});

Expected behavior

Like the npm plugin, if it cannot find a version, it should return "0.0.0.0". No error should be thrown.

@interactwithankush
Copy link

I would like to contribute. Can I please be assigned to this problem?

@hipstersmoothie
Copy link
Collaborator

Feel free to submit a PR. I don't like assigning them because during hacktoberfest a lot of people call "dibs" but few usually follow through

@christyjacob4
Copy link

@hipstersmoothie doesn't #1396 already fix this ?

@ratnamal
Copy link

ratnamal commented Oct 1, 2020

@hipstersmoothie
Is this issue fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants