Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video standards in General info for Edit ROM Features are initially blank #20

Closed
intvsteve opened this issue Jan 14, 2017 · 6 comments
Closed
Assignees
Labels
Projects

Comments

@intvsteve
Copy link
Owner

@intvsteve intvsteve commented Jan 14, 2017

Not sure if there's a bug in the display, or if the data is not defined.

Have not checked on Mac.

@intvsteve intvsteve self-assigned this Feb 4, 2017
@intvsteve intvsteve added the bug label Feb 4, 2017
@intvsteve intvsteve changed the title WPF: Video standards in General info for Edit ROM Features are initially blank Video standards in General info for Edit ROM Features are initially blank Feb 4, 2017
@intvsteve
Copy link
Owner Author

@intvsteve intvsteve commented Feb 4, 2017

Yep… this happens on Mac, too.

@intvsteve
Copy link
Owner Author

@intvsteve intvsteve commented Feb 5, 2017

Looks like you need to NOT show ROM details. Happens on first invocation of Edit ROM Features dialog. Subsequent invocations work as expected.

@intvsteve
Copy link
Owner Author

@intvsteve intvsteve commented Feb 5, 2017

Uh… this is getting really slippery. Stopped happening. Don't think this is ever written own anywhere, and there's no obvious explanation in code aside from potential race conditions. Weird.

@intvsteve
Copy link
Owner Author

@intvsteve intvsteve commented Feb 14, 2017

In Windows, if you launch and haven't already got ROM details showing, these are blank. May be a release optimization that somehow is causing the static data to not initialize?

@intvsteve
Copy link
Owner Author

@intvsteve intvsteve commented Feb 14, 2017

OK... looks like the root cause is that various ROMs believe NTSC is "required", but the UI isn't putting that option into the list as a selectable option. Not sure why that is, to be honest... I.e. why ROMs would have 'required' be the default. Need to revisit that.

@intvsteve intvsteve added this to Bugs In Work in Bug Fixes Dec 1, 2017
intvsteve added a commit that referenced this issue Dec 2, 2017
When adding a new ROM, we will combine features. If the new ROM is unknown, it would "combine" the 'Tolerates' setting (default for most) with 'Enhances' for video standard support - which means 'Unknown'. However, the result is that the ORing of those together produces a 'required' value for the video standard, which does not make sense.

To address existing behavior of saved ROM lists, coerce the read and and write operations on the Ntsc and Pal properties.

Also, fix how flags are combined to prevent this escalation from happening with other features. Unfortunately, if there are bugged ROM files out there for things like JLP and other features, they will remain bugged until the user manually fixes them, or deletes / re-adds the ROM after getting this fix.
intvsteve added a commit that referenced this issue Dec 2, 2017
…dard-setting

Fix issue #20 - #20
@intvsteve intvsteve moved this from Bugs In Work to Unreleased Fixes in Bug Fixes Dec 3, 2017
@intvsteve intvsteve moved this from Unreleased Fixes to Fixed Bugs in Bug Fixes Mar 17, 2018
@intvsteve
Copy link
Owner Author

@intvsteve intvsteve commented May 23, 2019

Fix released in #297.

@intvsteve intvsteve closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bug Fixes
  
Fixed Bugs
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant