Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROM files with more than one period in them may not work correctly when added to cartridge. #202

Closed
intvsteve opened this Issue Jun 15, 2018 · 0 comments

Comments

1 participant
@intvsteve
Copy link
Owner

intvsteve commented Jun 15, 2018

Operating system version

Any

Program version (from About box)

1.0.0.2918

Expected behavior

Ms. Pac-Man and Ms. Night Stalker should both play correctly from cartridge.

Actual behavior

They don't.

Steps to reproduce

Put files with '.' in the name, like Ms. Pac-Man.bin and Ms. Night Stalker.bin, in to the same directory on disk, then add both to your menu, update cart, and try to play.

Crash log if available (paste or attach)

N/A

@intvsteve intvsteve added the bug label Jun 15, 2018

@intvsteve intvsteve self-assigned this Jun 15, 2018

@intvsteve intvsteve added this to New Bugs in Bug Fixes via automation Jun 15, 2018

intvsteve added a commit that referenced this issue Jun 23, 2018

Fix issue #202 - multiple dots in file name
User encountered this bug when Ms. Pac-Man and Ms. Night Stalker were both in the same folder. The but was due to using System.IO.Path.ChangeExtension after removing the original file extension (.bin) and replacing it with _bin. Subsequent code then assumed no file extension would be present, so Ms. Pac-Man_bin changed to Ms.luigi. This would happen for both files, resulting in only one .luigi file being on disk and sent to the cartridge.

intvsteve added a commit that referenced this issue Jun 23, 2018

Merge pull request #205 from intvsteve/intvsteve-fix-issue202-dots-in…
…-filename

Fix issue #202 - multiple dots in file name

@intvsteve intvsteve moved this from New Bugs to Unreleased Fixes in Bug Fixes Jun 23, 2018

@intvsteve intvsteve closed this Mar 6, 2019

Bug Fixes automation moved this from Unreleased Fixes to Fixed Bugs Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.