Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor metadata needs protection for control characters #280

Closed
intvsteve opened this issue Feb 22, 2019 · 2 comments
Closed

Vendor metadata needs protection for control characters #280

intvsteve opened this issue Feb 22, 2019 · 2 comments
Assignees
@intvsteve
Labels
bug tech debt General code cleanup
Projects
Bug Fixes

Comments

@intvsteve
Copy link
Owner

Although issue #257 mentions that Vendor (publisher) metadata will be fixed as part of a deeper change, it is presently directly exposed on the ProgramDescription class.

Ergo: Apply same fix for Vendor on ProgramDesription as for Name and ShortName.
@intvsteve intvsteve added bug tech debt General code cleanup labels Feb 22, 2019
@intvsteve intvsteve self-assigned this Feb 22, 2019
@intvsteve intvsteve added this to New Bugs in Bug Fixes via automation Feb 22, 2019
@intvsteve
Copy link
Owner Author

This reminds me … It may be worth the effort to explore retiring ProgramDescription as a public class and instead only work via the interface IProgramDescription. This could act as a stepping stone to moving to IProgramRomInformation. The notion is that the current strategy of using XML Attributes is merely a patch.

Now that issues like this have been identified, moving away from the expediency of the automagical XML serialization services to something more targeted specifically for serialization may make more sense.

intvsteve added a commit that referenced this issue Feb 23, 2019
@intvsteve
Fix issue #280 - Vendor string needs XML protection
dea648f 
Since Vendor may be sourced from metadata, it needs the addition protection afforded from MetadataString as pertaining to XML serialization.
@intvsteve intvsteve mentioned this issue Feb 23, 2019
Merged
@intvsteve intvsteve moved this from New Bugs to Unreleased Fixes in Bug Fixes Feb 26, 2019
@intvsteve
Copy link
Owner Author

Fixed in commit cb0a5aa

Bug Fixes automation moved this from Unreleased Fixes to Fixed Bugs Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@intvsteve intvsteve

Labels
bug tech debt General code cleanup
Projects
Bug Fixes
  
Fixed Bugs
Milestone
No milestone
Development

No branches or pull requests
1 participant
@intvsteve