Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There may be unwanted prompts for >1 LTO Flash! connected #41

Open
intvsteve opened this Issue Mar 12, 2017 · 5 comments

Comments

1 participant
@intvsteve
Copy link
Owner

intvsteve commented Mar 12, 2017

Testing filtering device connections based on USB VID and PID. Noticed that when "switching" devices, the prompt appeared while in the background (behind the dialog prompt) the validation progress bar had appeared.

In this case, had plugged in a generic USB<->Serial stick, and the validation code was waiting for the beacon from the hardware (which would never come).

Thing is... when explicitly choosing to switch connections, the prompt to "connect to detected device" should NOT appear.

Minor issue, but it can be annoying. As I'm down to one functional unit for the time being, testing with multiple real devices is not possible.

@intvsteve intvsteve self-assigned this Mar 12, 2017

@intvsteve intvsteve added this to New Bugs in Bug Fixes Dec 1, 2017

@intvsteve intvsteve added the bug label Dec 1, 2017

@intvsteve intvsteve moved this from New Bugs to Bugs In Work in Bug Fixes Dec 2, 2017

@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Dec 2, 2017

Looks like CreationInfo during the selection process is falling on the floor.

When you choose to connect to a different LTO Flash!, we create a "new" device and add it to the collection of peripherals. The state data passed along here is expressed as a dictionary. Eventually, we reach the function Device.GetLtoFlashDevice().

That function only looks directly at the passed in state data as a DeviceCreationInfo instance -- it does not consider the usage of a Dictionary which contains multiple bits of information.

The fix here is to clean up how that state is processed to be consistent.

@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Dec 2, 2017

Secondary bug:
We should not prompt to select a device when the new port arriving in the system is not an LTO Flash! device

@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Dec 2, 2017

Tertiary bug:
When the first bug occurs, the other side effect is that, when two LTO Flash! devices are connected, the port selection dialog shows two items:

  • The new, non-LTO Flash! port
  • The currently connected LTO Flash!

If it were to show anything at all, it should show the other valid LTO Flash! device!

This issue will be avoided by fixing the secondary bug -- namely if the newly arrived port does not belong to an LTO Flash! device, then don't show the dialog at all.

@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Dec 2, 2017

NOTE: It is possible that the user has disabled the 'Verify port' feature, in which case we will display the dialog if there is at least one other LTO Flash! device available to connect to. So the tertiary bug also needs to be fixed.

intvsteve added a commit that referenced this issue Dec 2, 2017

Address Issue #41 - Dialog prompt when adding non-LTO Flash! device t…
…o system. We were ignoring the directive to force device attachment when switching between devices, resulting in the device selection dialog appearing.

intvsteve added a commit that referenced this issue Dec 2, 2017

Address two related problems found when investigating issue #41:
* If the only newly arrived serial ports are not *real* LTO Flash! devices, don't show the dialog
* Ensure that if >1 ***LTO Flash!*** is connected, all will be available in the dialog.

Added a method to really, really check the device. So if you have a ***LTO Flash!*** whose FTDI chip hasn't been configured, you'll need to manually connect to it and disable the 'only connect to validated devices' option.
@intvsteve

This comment has been minimized.

Copy link
Owner Author

intvsteve commented Dec 2, 2017

Fixes submitted to master.

intvsteve added a commit that referenced this issue Dec 3, 2017

@intvsteve intvsteve moved this from Bugs In Work to Unreleased Fixes in Bug Fixes Dec 3, 2017

@intvsteve intvsteve moved this from Unreleased Fixes to Fixed Bugs in Bug Fixes Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.