Remove support for IE < 9? #116

Closed
nenadjelovac opened this Issue Aug 2, 2016 · 17 comments

Projects

None yet

4 participants

@nenadjelovac
Member
nenadjelovac commented Aug 2, 2016 edited

@inuitcss/core It's been highlighted in comments on another issue that PostCSS could handle IE < 9 support for users that really need it (via node-pixrem perhaps). Removing official support for oldie browsers would make the code lighter and make us more nimble in inuitcss development ;)

@anselmh
Member
anselmh commented Aug 3, 2016

I think we should do this. Also, shouldn’t we embrace using PostCSS’ autoprefixer anyway?

@csshugs csshugs added a commit that referenced this issue Aug 3, 2016
@csshugs csshugs [refs #116] Remove IE<9 support e0a203b
@csswizardry
Member

This completely removes IE8 support. As in, this will stop fundamental parts of the framework working in IE8. We will no longer have any layout. I think this is too destructive. I don’t want to provide full support for IE8, but removing layout completely is a step too far.

@csshugs
Member
csshugs commented Aug 4, 2016

@csswizardry
Why is layout affected by this?

@csswizardry
Member
csswizardry commented Aug 4, 2016 edited

Because the layout system uses the font-size hack, and using rems will stop the hack from working in browsers that don’t support them.

@nenadjelovac
Member

Damn, forgot about that!

@csshugs check these lines.

@csshugs
Member
csshugs commented Aug 4, 2016

@nenadjelovac @csswizardry
Well we could just take the @if away there:

@if ($inuit-use-markup-fix == false) {
  font-size: $inuit-global-font-size;
  font-size: 1rem;
}
@csshugs
Member
csshugs commented Aug 4, 2016

...I mean, if it's just the layout that concerns you.

@nenadjelovac
Member
nenadjelovac commented Aug 4, 2016 edited

@csshugs yes, but it's used in font size mixin as well.

@inuitcss/core I think we should agree what inuitcss' intent is.

  1. If we officially offer support for IE < 9 then we have to agree how far we want to take it. In that case $inuit-oldIE remains.
  2. If we want to just offer fallback where we know something will break (layout, font-size), then we can do it the way @csshugs suggested.
@csshugs
Member
csshugs commented Aug 4, 2016

Nr. 2 makes our lives easier, I guess.

I mean, IE 8! We should do the least possible to support IE 8.

@csswizardry
Member

I mean, IE 8! We should do the least possible to support IE 8.

In principle I agree, but it would be irresponsible to leave IE8 users looking at a page full of font-size: 0; layouts.

@csshugs
Member
csshugs commented Aug 4, 2016

but it would be irresponsible to leave IE8 users looking at a page full of font-size: 0; layouts.

That's why I'd vote for Nr. 2.

@csshugs csshugs added a commit that referenced this issue Aug 5, 2016
@csshugs csshugs [refs #116] Make it IE<9 compatible 197830c
@csshugs
Member
csshugs commented Aug 5, 2016

When you have a look at the last commit, you see that it's

A. IE8 compatible
B. Simple (no Sass magic to detect whether we support IE8 or not)

If we some day will decide to drop IE8 support, all we have to do is remove (currently) three lines of code.

@csshugs
Member
csshugs commented Aug 29, 2016

@inuitcss/core
What do you think about it looking at this two commits, i.e. take away the Sass logic and just put the font-size fallback in there? This would keep the IE8 compatibility and makes the Sass code cleaner. Feels like a solid compromise to me.

@nenadjelovac
Member

@csshugs I'm still down with that solution ;)

@csshugs
Member
csshugs commented Aug 29, 2016

@nenadjelovac So you want to completely drop IE8 support? Or let everything as is?

@nenadjelovac
Member
nenadjelovac commented Aug 29, 2016 edited
  1. If we officially offer support for IE < 9 then we have to agree how far we want to take it. In that case $inuit-oldIE remains.
  2. If we want to just offer fallback where we know something will break (layout, font-size), then we can do it the way @csshugs suggested.

@csshugs I vote for No. 2 :) Hope that helps :)

@csshugs csshugs added a commit that referenced this issue Sep 23, 2016
@csshugs csshugs [refs #116] Remove oldIE var 3a0e463
@csshugs csshugs added a commit that referenced this issue Sep 23, 2016
@csshugs csshugs [refs #116] Remove oldIE condition c767111
@csshugs csshugs added a commit that referenced this issue Sep 23, 2016
@csshugs csshugs [refs #116] Update tests ce08bd4
@csshugs
Member
csshugs commented Oct 7, 2016

#176 is merged.

@csshugs csshugs closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment